On 01/15/2013 11:17 AM, Aharon Robbins wrote: > Hi Guys, > > I just got the below bug report. Apparently it has to do with the > fact that xalloc.h includes <stddef.h>. > > Any objection to changing the order of includes as suggested? Or > how about moving the include of <stddef.h> into dfa.c itself?
I'd rather see a patch that makes dfa.h work standalone - that is, add an #include <stddef.h> into dfa.h, without touching dfa.c at all. These days, it is considered poor practice to write a header that cannot be used without first including some other header. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
