From 2ba43c99fb7d443c0b907503519a9934872bcdaf Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 11 Oct 2013 11:47:54 -0700 Subject: [PATCH 2/4] maint: fix typo in NEWS * NEWS: Fix/improve example commands in most recent entry. The LC_ALL envvar setting goes before grep, not before printf. Don't reference src/ in the second example command, and do specify the locale. --- NEWS | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index a273367..6f07c13 100644 --- a/NEWS +++ b/NEWS @@ -6,10 +6,11 @@ GNU grep NEWS -*- outline -*- grep's \s and \S failed to work with multi-byte white space characters. For example, \s would fail to match a non-breaking space, and this - would print nothing: LC_ALL=en_US.utf8 printf '\xc2\xa0' | grep '\s' + would print nothing: printf '\xc2\xa0' | LC_ALL=en_US.UTF-8 grep '\s' A related bug is that \S would mistakenly match an invalid multibyte - character. E.g. this would match: printf '\x82\n' | src/grep '^\S$' - [bug present since 2.6] + character. For example, the following would match: + printf '\x82\n' | LC_ALL=en_US.UTF-8 grep '^\S$' + [bug present since grep-2.6] grep -i would segfault on systems using UTF-16-based wchar_t (Cygwin) when converting an input string containing certain 4-byte UTF-8 -- 1.8.4.299.gb3e7d24