URL:
<http://savannah.gnu.org/bugs/?44768>
Summary: gdiffmk(1) is not Solaris 10 /bin/sh compatible -
PATCH provided
Project: GNU troff
Submitted by: None
Submitted on: Wed 08 Apr 2015 07:05:21 AM UTC
Severity: 3 - Normal
Item Group: Crash
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
Planned Release: None
_______________________________________________________
Details:
Greetings,
When building the git version of groff (2015/04/04) to check the fix
for https://savannah.gnu.org/bugs/?44708, I discovered that the
installed gdiffmk(1) did not function, with the error:
syntax error at line 22: `cmd=$' unexpected
Of all the installed shell scripts (11 in total), gdiffmk(1) is the
only one to use the $(...) syntax, instead of the older `...` syntax,
and thus the only one to fail Solaris 10 a test of the form:
/bin/sh -n <file>
Only a seven instances exist:
grep -n '$(' /pkgs/64-bit/release/groff-git_2014_04_04/bin/gdiffmk
22:cmd=$( basename $0 )
112: "Cannot write directory \`$( dirname "$2" )'."
166: ADDMARK=$( RequiresArgument "${OPTION}" $2 ) &&
170: CHANGEMARK=$( RequiresArgument "${OPTION}" $2 ) &&
174: DELETEMARK=$( RequiresArgument "${OPTION}" $2 ) &&
181: MARK1=$( RequiresArgument "${OPTION}" $2 ) &&
194: DIFFCMD=$( RequiresArgument "${OPTION}" $2 ) &&
The attached patch, allows the script to pass /bin/sh -n test on
Solaris 10, as well as simple run tests such as, 'gdiffmk' and
'gdiffmk --version', and 'gmake check' (from source root), no further
testing has not been conducted.
Regards,
Peter Bray
Sydney, Australia
PS: This patch is submitted in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. I hereby donate
it to the groff project, to do with as the maintainer(s) see fit,
including distribution under any license or licenses they deem fit,
now or in the future. Copyright may be assigned as the maintainer(s)
see fit. It yours!
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Wed 08 Apr 2015 07:05:22 AM UTC Name:
groff-git_2014_04_04-solaris_bin_sh.patch Size: 1kB By: None
<http://savannah.gnu.org/bugs/download.php?file_id=33589>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?44768>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
bug-groff mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-groff
