Update of bug #61454 (project groff):
Status: None => Invalid
Assigned to: None => gbranden
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #1:
Please read the comment immediately above the material you're patching.
# Unfortunately, the shell is a nightmarish hellscape of quoting issues.
# Naïve attempts to solve the problem fail when arguments to nroff
# contain embedded whitespace or shell metacharacters. The solution
# below works with those, but there is insufficient quoting in -V (dry
# run) mode, such that you can't copy-and-paste the output of 'nroff -V'
# if you pass it a filename like foo"bar (with the embedded quotation
# mark) and expect it to run without further quoting.
There are at least 2 problems with your patch.
1. It ignores the meaning of the -V option and executes the command instead of
writing it to the standard output stream.
$ echo "foobar" | GROFF_TEST_GROFF=./test-groff ./nroff -V -t -ms | cat -s
foobar
2. It exhibits the very problem warned about in the comment.
$ GROFF_TEST_GROFF=./test-groff ./nroff -V -t -ms foo\"bar.man
./nroff: 1: eval: Syntax error: Unterminated quoted string
I do not see how this patch constitutes an improvement on the existing code in
any way, and the attached description does not help me to understand how the
existing code is inadequate, if at all.
Please take the time to clearly describe a defect along with, prior to, or
instead of providing a patch.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?61454>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
