Follow-up Comment #10, bug #63133 (project groff):

[comment #9 comment #9:]
> [comment #8 comment #8:]
> > The underlying issue, with pdfroff, was fixed by
> >
[https://osdn.net/users/keith/pf/groff-pdfmark/scm/commits/5d88cef1407d5bb625a1c23a888976f6efa80fab
commit 5d88cef1407d5bb625a1c23a888976f6efa80fab]:

> > 2023-02-24  Keith Marshall  <address@hidden>
> > 
> >     Do not emit redundant 'pdfhref Z' records.
> > 
> >     * pdfroff.sh [grohtml-info] (pdfhref Z): Adapt awk script, to emit...
> >     (pdfhref Z 0 0 0): ...this conditionally, only if at least one prior
> >     record has been emitted; delete unconditional emission, which caused
> >     the anomaly reported as groff issue #63133.


> > 
> > Okay to close?
> 
> Hi Keith,
> 
> I'd prefer not to close it here since it still affects groff's
> pdfroff and therefore likely the 1.23.0 release.
> 
> Unless we cherry-pick the fix...

Okay.  You might consider just copying my latest pdfroff.sh, accompanying
pdfroff.1.man, and everything in my tmac/ subtree, *except* s.tmac, (which is
just a verbatim copy of yours, at the time I forked groff-pdfmark, and yours
has evolved since then), but I'll leave it to your discretion.

> BTW, are you sure about that commit link?

Oops! It looks like I copied, and pasted the wrong link; it should have been
[https://osdn.net/users/keith/pf/groff-pdfmark/scm/commits/69c99bee3ce93ddaae89026d61cea9bc75ecf453
commit #69c99bee]; (I should have noticed that the hash wasn't as I
expected).

> It seems to go to this change:

> Clean up Z-shell initialization logic.
> 
> * pdfroff.sh [ZSH_VERSION]: Tidy initialization code for...
> (NULLCMD, emulate sh): ...these; bring it more into alignment with
> contemporary GNU autoconf usage.


Indeed.  That's the immediate parent of the intended commit.

> In any case I'll take responsibility for it, on the assumption I'll
> be able to cherry-pick, and mark it "Confirmed" for want of a status
> that means "fix available elsewhere".

Okay; I'll leave it with you.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63133>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/


Reply via email to