Follow-up Comment #10, bug #66653 (group groff):

Hi Deri,

At 2025-08-30T05:46:29-0400, G. Branden Robinson wrote:
>> fine when the diversion is output as a heading but needs to be
>> converted back to text to be used for the bookmark. Traditionally
>> this was done by calling .asciify which converted glyph nodes and
>> word space nodes back to text:-
>> 
>> .{type: glyph_node, character: "F", diversion level: 1},
>> {type: glyph_node, character: "i", diversion level: 1},
>> {type: glyph_node, character: "r", diversion level: 1},
>> {type: glyph_node, character: "s", diversion level: 1},
>> {type: glyph_node, character: "t", diversion level: 1},
>> {type: word_space_node, diversion level: 1},
>> 
>> But, oddly, fails to convert:-
>> 
>> {type: glyph_node, character: "\u260E", diversion level: 1},
>> 
>> Back to \[u260E], possibly the code was written before the advent of
>> preconv.
> 
> That sounds like a bug I want to fix.
> 
> Let me see if it's live in Git today.
[...]
> Hmm, yup.  Looks like a bug in `asciify` all right.

I think I have this licked.

I'm attaching (or trying too--let's see if Savannah's email gateway can
cope) a diff of my changes since my last push (just a couple of hours
ago).

Here it is in action:


$ cat ATTIC/unicode-char-in-diversion.groff
.box DIV
hello \[u260E] world
\#hello \[ru] world
.br
.box
.DIV
.\"pm DIV
.chop DIV
.asciify DIV
.\"pm DIV
.DIV
\X'pdf: ignoreme \*[DIV]'
$ ./build/test-groff -Z ATTIC/unicode-char-in-diversion.groff
x T ps
x res 72000 1 1
x init
p1
x font 5 TR
f5
s10000
md
DFd
V12000
H72000
thello
wx font 12 ZD
f12
h2500
Cu260E
wf5
h9690
tw
H111310
torld
wh2500
thello
wf12
h2500
Cu260E
wf5
h9690
tw
H169230
torld
V12000
H185340
x X pdf: ignoreme hello \[u260E] world
n12000 0
x trailer
V792000
x stop


Please try this out and let me know if it is satisfactory, or isn't.


(file #57604)

    _______________________________________________________

Additional Item Attachment:

Name: deri-66653.diff                Size: 10KiB
    <https://file.savannah.gnu.org/file/deri-66653.diff?file_id=57604>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-3f10ac0e069065aa2f5279465705751cdb199100.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66653>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to