Follow-up Comment #19, bug #67571 (group groff):

It's worth noting that I now think the quoted code in comment #18 is not
correct.

`using_character_classes` is not, I now think, intended as an optimization of
any kind, but rather to put the parser into a special state such that special
character identifiers are looked up first in `char_class_dictionary`.

See bug #67711.

I furthermore acknowledge that my comments on several character class-related
are coming thick and fast and I'm venturing and withdrawing hypotheses at a
rapid rate.

I won't apologize for that, but offer it as an object lesson: this is why we
(should) write comprehensive documentation and unit tests for features when
implementing them.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?67571>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to