Update of bug #64054 (group groff):

                Category:                 General => Core
              Item Group:      Build/Installation => Lint
                  Status:                    None => Fixed
             Assigned to:                    None => gbranden
             Open/Closed:                    Open => Closed
         Planned Release:                    None => 1.24.0
                 Summary: [build] replace src/libs/libgroff/getopt.c with
gnulib "getopt-gnu" module => [libgroff] replace src/libs/libgroff/getopt.c
with gnulib "getopt-gnu" module

    _______________________________________________________

Follow-up Comment #2:

I took care of this about a year ago.


commit fb54989456b11cefbc9892ebea589be5ece32241
Author: G. Branden Robinson <[email protected]>
Date:   Wed Nov 27 05:28:27 2024 -0600

    bootstrap.conf: Add "getopt-gnu" module.
    
    * bootstrap.conf: Add "getopt-gnu" to `gnulib_modules`.

commit 68968197dc8a4c9c1320b6908767c06229614907
Author: G. Branden Robinson <[email protected]>
Date:   Wed Nov 27 13:37:12 2024 -0600

    [libgroff]: Drop internal getopt implementation.
    
    ...in favor of gnulib's.
    
    * src/include/getopt.h:
    * src/include/getopt_int.h:
    * src/include/gettext.h:
    * src/libs/libgroff/getopt.c:
    * src/libs/libgroff/getopt1.c: Delete.
    
    * src/libs/libgroff/libgroff.am: Drop foregoing `.c` files from
      `libgroff_a_SOURCES` macro.

commit 860ab0871104495e6db4a4fc0f959b2db2304b93
Author: G. Branden Robinson <[email protected]>
Date:   Sat Nov 30 03:29:53 2024 -0600

    Continue removal of local getopt implementation.
    
    * src/include/lib.h:
    * src/libs/libgroff/libgroff.am (libgroff_a_CPPFLAGS):
    * src/utils/pfbtops/pfbtops.c:
    * src/utils/xtotroff/xtotroff.c: Fix straggling definitions of
      `__GETOPT_PREFIX`, which broke the build on Solaris 10.  Continues
      commit 68968197dc, 27 November.
    
    Fixes:
    
      CXX      src/devices/grodvi/dvi.o
    In file included from ./src/include/driver.h:19:0,
                     from src/devices/grodvi/dvi.cpp:30:
    ./src/include/lib.h:36:0: warning: "__GETOPT_PREFIX" redefined
     #define __GETOPT_PREFIX groff_
     ^
    In file included from src/devices/grodvi/dvi.cpp:20:0:
    ./src/include/config.h:1244:0: note: this is the location of the previous
definition
     #define __GETOPT_PREFIX rpl_
     ^





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64054>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature

Reply via email to