Update of bug #67950 (group groff):
Category: General => Core
Severity: 3 - Normal => 1 - Wish
Status: None => Rejected
Assigned to: None => gbranden
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #1:
[comment #0 original submission:]
> Subject: [groff] use "groff" outside of loops in
> "check-delimiter-validity.sh"
>
> File: src/roff/groff/tests/check-delimiter-validity.sh
>
> I see no need to process each test-line with "groff" instead of
> collecting these in a file and use that as an input for
> "groff".
>
> The current processing time is excessive.
1. Test cases are not required to be performant. No one is required to run
them. (Submitters of patches are *strongly urged* to, though.)
2. It would complicate the test script to automatically generate an
identifier for each line of output and verify that the actual output matched
expectations, and this script is new enough that even its present "simplistic"
form it may require elaboration to work around host differences in quoting
requirements.
3. Running _groff_ anew each time means that we can be virtually certain of
the formatter's state when each delimited escape sequence is interpreted
(since it's the first thing appearing in the input), something that until
recently was not true even in the event of newlines in the input--see bug
#63142. I value having a test script that I can easily throw at old versions
of GNU _troff_, or even other _troff_s.
Rejecting.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?67950>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
