Update of bug #68024 (group groff):
Status: In Progress => Fixed
Open/Closed: Open => Closed
Planned Release: None => 1.25.0
_______________________________________________________
Follow-up Comment #1:
commit 46fdbfef50d86347b64fd0d2ecca90cc99315523
Author: G. Branden Robinson <[email protected]>
Date: Sun Mar 15 16:15:19 2026 -0500
Refactor: migrate putenv(3) -> setenv(3) (1/3).
* src/devices/grops/ps.cpp (main):
* src/devices/grops/psrm.cpp (resource_manager::output_prolog):
* src/roff/troff/input.cpp (main): Do it.
Begins fixing <https://savannah.gnu.org/bugs/?68024>.
commit 81afd4cf4339772fecd660a63f7ab9d6cb1fdcef
Author: G. Branden Robinson <[email protected]>
Date: Sun Mar 15 16:53:41 2026 -0500
Refactor: migrate putenv(3) -> setenv(3) (2a/3).
* src/roff/groff/groff.cpp: Refactor: migrate from putenv(3) to
setenv(3) (1/4). Drop global pointer variable `groff_font_path`.
(xsetenv): New function wraps setenv(3) as `xputenv()` does putenv(3).
(main): Replace local string `e` containing shell-like environment
variable assignment with string `value` containing only the value to
be assigned. Call `xsetenv()` with `GROFF_FONT_PATH` string literal
and `value` as arguments. Because, unlike putenv(3), setenv(3) makes
its own copies of its C string operands, we no longer need to reserve
statically allocated storage for them to keep them from going out of
scope.
(xexit): Stop free(3)ing abandoned variable `groff_font_path`.
commit 0ec2feb8b067cf26f0141878cca0b9d717441bb4
Author: G. Branden Robinson <[email protected]>
Date: Sun Mar 15 17:55:02 2026 -0500
Refactor: migrate putenv(3) -> setenv(3) (2b/3).
* src/roff/groff/groff.cpp: Refactor: migrate from putenv(3) to
setenv(3) (2/4). Drop global pointer variable `saved_path`.
(main): Drop local string `g` containing shell-like environment
variable assignment in favor of straightforward call to `xsetenv()`
with `GROFF_PATH__` string literal and existing `path` (populated by
`getenv("PATH")`) as arguments. Because, unlike putenv(3), setenv(3)
makes its own copies of its C string operands, we no longer need to
reserve statically allocated storage for them to keep them from going
out of scope.
(xexit): Stop free(3)ing abandoned variable `saved_path`.
commit 99aef391f860ccfcaceff95bb3e631dc58edc12c
Author: G. Branden Robinson <[email protected]>
Date: Sun Mar 15 18:36:57 2026 -0500
Refactor: migrate putenv(3) -> setenv(3) (2c/3).
* src/roff/groff/groff.cpp: Refactor: migrate from putenv(3) to
setenv(3) (3/4). Drop global pointer variable `groff_bin_path`.
(main): Stop initially populating `newpath` local variable with
"PATH=" in favor of straightforward call to `xsetenv()` with `PATH`
string literal and contents of `newpath` groff string as arguments.
Because, unlike putenv(3), setenv(3) makes its own copies of its C
string operands, we no longer need to reserve statically allocated
storage for them to keep them from going out of scope.
(xexit): Stop free(3)ing abandoned variable `groff_bin_path`.
commit 95cedcfd9a6dd055893f7a43b039eb99b6cc58bf
Author: G. Branden Robinson <[email protected]>
Date: Sun Mar 15 18:39:54 2026 -0500
Refactor: migrate putenv(3) -> setenv(3) (2d/3).
* src/roff/groff/groff.cpp: Refactor: migrate from putenv(3) to
setenv(3) (4/4).
(xputenv): Drop no-longer-used function.
commit 751661bed609a1155caa41d5bde4d1dda7d6961e
Author: G. Branden Robinson <[email protected]>
Date: Sun Mar 15 19:16:13 2026 -0500
bootstrap.conf: Drop `putenv` Gnulib module.
Fixes <https://savannah.gnu.org/bugs/?68024>.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?68024>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
