URL: <https://savannah.gnu.org/bugs/?68793>
Summary: [pdfmom] determine if `TMPDIR` environment variable
assignment is useless
Group: GNU roff
Submitter: gbranden
Submitted: Sun 18 Oct 2026 01:29:01 PM UTC
Category: Utilities
Severity: 2 - Minor
Item Group: Refactoring
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Unlocked
Planned Release: None
_______________________________________________________
Follow-up Comments:
-------------------------------------------------------
Date: Sun 18 Oct 2026 01:29:01 PM UTC By: G. Branden Robinson <gbranden>
I can't see that this line of code is doing any good.
$ git grep -n TMPDIR src/utils
src/utils/pdfmom/pdfmom.pl:51:$ENV{TMPDIR}=$ENV{GROFF_TMPDIR} if
exists($ENV{GROFF_TMPDIR});
It does not appear that preparing the environment thus for the programs
_pdfmom_ builds into its pipeline is necessary.
src/libs/libgroff/tmpfile.cpp:42:#define GROFF_TMPDIR_ENVVAR "GROFF_TMPDIR"
src/libs/libgroff/tmpfile.cpp:44:#define TMPDIR_ENVVAR "TMPDIR"
src/libs/libgroff/tmpfile.cpp:48:// (giving priority to WIN32_TMPDIR_ENVVAR)
src/libs/libgroff/tmpfile.cpp:49:#define WIN32_TMPDIR_ENVVAR "TMP"
src/libs/libgroff/tmpfile.cpp:50:#define MSDOS_TMPDIR_ENVVAR "TEMP"
src/libs/libgroff/tmpfile.cpp:54:# define DEFAULT_TMPDIR P_tmpdir
src/libs/libgroff/tmpfile.cpp:57:# define DEFAULT_TMPDIR "/tmp"
src/libs/libgroff/tmpfile.cpp:78: (tem = getenv(GROFF_TMPDIR_ENVVAR)) ==
0 /* nullptr */
src/libs/libgroff/tmpfile.cpp:79: && (tem = getenv(TMPDIR_ENVVAR)) == 0
/* nullptr */
src/libs/libgroff/tmpfile.cpp:85: && (tem = getenv(WIN32_TMPDIR_ENVVAR))
== 0 /* nullptr */
src/libs/libgroff/tmpfile.cpp:86: && (tem = getenv(MSDOS_TMPDIR_ENVVAR))
== 0 /* nullptr */
src/libs/libgroff/tmpfile.cpp:90: tem = DEFAULT_TMPDIR;
src/roff/groff/groff.1.man:1915:.I GROFF_TMPDIR
src/roff/groff/groff.1.man:1920:.I \%TMPDIR
src/roff/groff/pipeline.c:367: if ((tmpdir = getenv("GROFF_TMPDIR")) == NULL
src/roff/groff/pipeline.c:368: && (tmpdir = getenv("TMPDIR")) == NULL)
src/utils/pdfmom/pdfmom.pl:51:$ENV{TMPDIR}=$ENV{GROFF_TMPDIR} if
exists($ENV{GROFF_TMPDIR});
If I'm correct, scotch that code.
**Not** targeting for _groff_ 1.25.0.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?68793>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
signature.asc
Description: PGP signature
