From: Peter �strand <[EMAIL PROTECTED]>
Subject: Color-patch 5
Date: Mon, 5 Jul 1999 22:00:07 +0200 (MET DST)
> I've added support for symbolic color names to GRUB.
Great!
> Patch included below. Comments are appreciated.
This patch is not consistent in some points.
You should not print any error message in the command-line parsing
function. Instead, you should set ERRNUM to something appropriate. I
do recommend you should use ERR_INVALID_COLOR (declare it in
shared.h).
This facility cannot be used in the configuration file, since the
parsers are separate. I want to fix the dirty (very dirty!) design
more generally, but for now, define parse_command_color or something,
and call the function in cmdline.c and stage2.c. The function should
be sharable, as all the function must know is a pointer to the
command-line buffer.
Regards,
OKUJI
----------------------------------------------------------------------
OKUJI Yoshinori <[EMAIL PROTECTED]> ^o-o^
http://duff.kuicr.kyoto-u.ac.jp/~okuji (in English) m /
