From: Klaus Reichl <[EMAIL PROTECTED]>
Subject: Comments to grub 0.5.94
Date: Sun, 7 Nov 1999 15:54:38 +0100 (CET)

> 1) Flushing the filesystem buffers in Linux is really a good thing,
>    however, it should be done on startup as well.  Other operations
>    resulting in changes on the disk prio to starting `grub' may not be
>    seen by `grub' without that.  (Patch follows).

  Thanks.

> 2) When creating /boot/grub/devices.map, the user should be informed.
>    Especially the first time the probe works OK, but leaves out the
>    floppy drive, if there is no floppy in that time.

  Don't you read the code?

> 4) --boot-drive & --install-partition is not very user friendly.
>    I did --root=DEVICE instead.  This is particularly useful to find the
>    default `menu.lst'.  (Patch follows).

  Great.

> 2) `root' & friends: There should be a way to look up things.  
>    I implemented `root' showing the ROOT when called without
>    parameters.  (Patch follows).

  That's a good feature. Probably `rootnoverify' should also show the
root device.

> 3) When hitting return (empty line), grub complains about illegal
>    command.  That's not nice.  (Patch follows).

  Why?

> 1) The completion rewrite is quite nice, one feature, however, has
>    been lost. 
>    Typeing:
>      some-command (DRIVE<TAB>
>    completes to
>      some-command (DRIVE)
>    The '/' allowing for next <TAB> is not there any more.

  This is intentional. I don't think it is good to add '/' blindly
though GRUB cannot know if the user wants to write a blocklist or a
filename. IMO, a completion should be performed only if what we can
expect after a string is unique.

----------------------------------------------------------------------
OKUJI Yoshinori  <[EMAIL PROTECTED]>           ^o-o^
http://duff.kuicr.kyoto-u.ac.jp/~okuji (in English)     m /

Reply via email to