From: Klaus Reichl <[EMAIL PROTECTED]>
Subject: terminal support - regards, comments, and bugs
Date: Fri, 1 Sep 2000 01:33:27 +0200 (CEST)

> Playing around happily with the newest checkout, i found&fixed:
> * one small but serious bug 
>   - mistake in --speed handling of builtins.c:serial_func
> * some minor deficiencies in stage2.c
>   - busy loop after grub_timeout stopped
>   - consistent appearance of the highlighted line 
>   - consistent help text and handling of UP-ARROW and DOWN-ARROW
>     character 

  Many thanks!

> I played around with a `menu.lst' starting like:
>   # go to serial device
>   serial --unit=0 --speed=19200 --word=8 --parity=no --stop=1
>   terminal --timeout=0 serial
> which is all default except SPEED, however, IMHO, some example like
> this should go to the manual, anyway.

  Agreed. I'll document the serial stuff before next release.

> -       if (c == 16)
> +       /* We told them above (at least in SUPPORT_SERIAL) to use
> +          '^' or 'v' so accept these keys
> +          BTW: 'n' & 'p' are also nice */
> +       if ((c == 16) || (c == '^') || (c == 'p'))

  This is not acceptable, because `p' is already used to enter a
password.

Okuji

Reply via email to