From: Alessandro Rubini <[EMAIL PROTECTED]>
Subject: [patch] speedup in data copy
Date: Sat, 9 Sep 2000 00:57:45 +0200
> While adding the "loading..." dots I noticed this one.
> It's a minor change, but I see no reasons to copy bytes when
> we can copy four of them at a time.
Approved. Please check in that patch yourself.
However, the ChangeLog entry is not good. You should write like
this:
* stage2/start.S (copy_buffer): Shift %ax to the left by 2
instead of 4.
Use movsl instead of movsb.
Capitalize the first character in the sentenses (unless this is
inappropriate). Append a period to each sentence. Write *all* changes
you made.
Thanks,
Okuji
>
> /alessandro
>
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/grub/ChangeLog,v
> retrieving revision 1.316
> diff -u -d -r1.316 ChangeLog
> --- ChangeLog 2000/09/08 21:30:16 1.316
> +++ ChangeLog 2000/09/08 22:55:08
> @@ -1,3 +1,7 @@
> +2000-09-09 Alessandro Rubini <[EMAIL PROTECTED]>
> +
> +
> 2000-09-09 OKUJI Yoshinori <[EMAIL PROTECTED]>
>
> From Alessandro Rubini:
> Index: stage2/start.S
> ===================================================================
> RCS file: /cvs/grub/stage2/start.S,v
> retrieving revision 1.4
> diff -u -d -r1.4 start.S
> --- stage2/start.S 2000/09/06 03:02:39 1.4
> +++ stage2/start.S 2000/09/08 22:55:09
> @@ -280,7 +280,7 @@
> address for next time */
>
> /* get the copy length */
> - shlw $4, %ax
> + shlw $2, %ax
> movw %ax, %cx
>
> /* save addressing regs */
> @@ -296,7 +296,7 @@
>
> /* perform copy */
> rep /* sets a repeat */
> - movsb /* this runs the actual copy */
> + movsl /* this runs the actual copy */
>
> /* restore addressing regs */
> popw %di
>
