From: Jeremy Katz <[EMAIL PROTECTED]>
Subject: [PATCH] Ensure serial device exists prior to use
Date: Wed, 8 Aug 2001 02:00:49 -0400
> We shouldn't try to use the serial terminal if the user hasn't properly
> configured it yet. This patch (against current CVS) makes it so ensures
> that we have set up a serial port prior to switching to a serial
> terminal.
Great.
> +/* Do we have a serial port set up? In the grub shell, we should check
> + if the fd is open */
> +int serial_exists(void)
> +{
> + grub_printf("serial_fd is %d\n", serial_fd);
Did you forget to remove a debug message?
More importantly, you should follow the GNU Coding Standards more
precisely. For example, the function definition above should be:
int
serial_exists (void)
...
And, the ChangeLog entries are not properly written. Please read the
standards and past logs written by us carefully.
Okuji
_______________________________________________
Bug-grub mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-grub
