Update of bug #49531 (project grub):
Planned Release: None => 2.03+
_______________________________________________________
Follow-up Comment #6:
I think at this point it is better to move discussion to grub-devel, savannah
bug tracker is not really suitable for patch review. Some comments regarding
second patch.
if (file->device->net->packs.count >= 20)
- {
- file->device->net->stall = 1;
+ file->device->net->stall = 1;
+
+ if (file->device->net->packs.count >= 100)
grub_net_tcp_stall (data->sock);
- }
This changes logic without any explanation why.
+ if (data->size_recv && data->downloaded_size >= file->size)
+ file->device->net->stall = 1;
file size may also be unknown in advance. We also already have code in
parse_line() to set stall and eof. Why is it not kicked in?
As for the original problem, looks OK but I would prefer to delay it for post
2.02; it is not critical and such changes always have potential for
regressions. Thank you for understanding.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?49531>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
Bug-grub mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-grub
