On Mon, Feb 26, 2018 at 10:59:24AM +0100, Joakim Bech wrote: > On Mon, Feb 26, 2018 at 10:45:46AM +0100, Daniel Kiper wrote: > > On Mon, Feb 26, 2018 at 09:57:34AM +0100, Joakim Bech wrote: > > > The of_path_of_nvme function introduced a build regression: > > > grub-core/osdep/linux/ofpath.c:365:21: error: comparison between > > > pointer > > > and zero character constant [-Werror=pointer-compare] > > > if ((digit_string != '\0') && (*part_end == 'p')) > > > > > > Update digit_string to compare against the char instead of the pointer. > > > > > > Signed-off-by: Joakim Bech <joakim.b...@linaro.org> > > > > CC-ing Vladimir. > > > > Pushed with some commit message changes. Thanks! However, this raises > > the question: why this code is build on ARM? Should we do not do that? > > > My bad here Daniel, I was building for the HiKey device which uses the > AArch64 GCC for most of its software components, but you are right, when > checking closer to the output from our builds I can see that we are > using the regular x86 toolchain when compiling grub. So a more correct
8-) Well... Eric, should not we build this code on SPARC only? I do not think it makes much sense to have that thing on platforms not supporting Open Firmware... > subject of my patch would have been: > "[PATCH] fix build regression in of_path_of_nvm" > > I apologize for not paying more attention to that before sending out the > patch. No problem, I know how it works. Daniel _______________________________________________ Bug-grub mailing list Bug-grub@gnu.org https://lists.gnu.org/mailman/listinfo/bug-grub