Nils Durner <[EMAIL PROTECTED]> writes:
>
> the attached patch fixes building on MinGW with "--with-threads=pthreads"
Looks good in principle, but some bits ought to be in a more autoconfy
style.
> -#ifdef HAVE_STRUCT_TIMESPEC
> +#if HAVE_STRUCT_TIMESPEC || SCM_I_GSC_USE_PTHREAD_THREADS
> pf ("typedef struct timespec scm_t_timespec;\n");
Does the detection of struct timespec go wrong somehow?
> +#ifndef __MINGW32__
> + sigset_t all_sigs;
> +
> sigfillset (&all_sigs);
> scm_i_pthread_sigmask (SIG_SETMASK, &all_sigs, NULL);
> +#endif
I think I'd rather either conditionalize on the existance of
pthread_sigmask, or perhaps make some dummy sigset stuff if it doesn't
exist.
> +#ifndef __MINGW32__
> + t->pthread,
> +#else
> + t->pthread.p,
> +#endif
What does that do?
> #if SCM_USE_PTHREAD_THREADS
> /* pthread_getattr_np not available on MacOS X and Solaris 10. */
> -#if HAVE_PTHREAD_ATTR_GETSTACK && HAVE_PTHREAD_GETATTR_NP
> +#if (HAVE_PTHREAD_ATTR_GETSTACK && HAVE_PTHREAD_GETATTR_NP) || __MINGW32__
Remind us what's wrong with the getstack detection ...
_______________________________________________
Bug-guile mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-guile
