Hi Bake, This patch looks great. I do have a couple of comments before applying. It would probably be useful to have input from others as well, so I'm copying guile-devel.
On Mon 16 Jan 2012 20:46, Bake Timmons <[email protected]> writes: > -@deffn {Scheme Procedure} resolve-module name [autoload=#t] [version=#f] > [#:ensure=#t] > +@deffn {Scheme Procedure} resolve-module name [autoload=#t [version=#f]] @ > + [#:ensure ensure=#t] Nesting the optional arguments in brackets can get a bit ugly. It is precise but verbose. But I suppose we should not encourage interfaces with many optional arguments, so perhaps it is a moot point. Also, it seems pedantic to repeat the keyword arguments (once as keyword, once as identifier). Surely #:foo=bar is unambiguous? Anyway, I'm interested what others think about changes like this. Cheers, Andy -- http://wingolog.org/
