Hi,

I have merged these patches, but I do have a question.

On Sun, 14 Jun 2026, Tomas Volf <[email protected]> wrote:
[...]
> -        (format #t "~a: ~a~%" prop val))))
> +    (let* ((default (list))
> +           (val (test-result-ref runner prop default)))
> +      (unless (eq? val default)
> +        (let ((val (string-trim-both
> +                    (with-output-to-string
> +                      (λ ()
> +                        (if pretty?
> +                            (pretty-print val #:per-line-prefix "            
>  ")
> +                            (display val)))))))
> +          (format #t "~a: ~a~%" prop val)))))
>  
>    (let ((result-kind (test-result-kind runner)))
>      ;; Skip tests not executed due to run list.

It seems to me that here `default' is suppose to be unique for the
purpose of checking if the property exist, by comparing the returned
value against the default one.  However, this will not work if the value
of the property is the empty list; (make-list 0) and (list) both return
'().

To fix this, I would recommend to define, possibly at top-level:

  (define no-property (list 'no-property))

and use that instead.

Thanks,
Olivier
-- 
Olivier Dion



Reply via email to