Am Sonntag, 30. Dezember 2012 schrieb Nikita Karetnikov:
> > +      `(#:tests? #f
> Ludo told me some time ago that it's necessary to write a comment when
> you disable tests. It should explain why they were disabled.

This is a mistake, thanks for spotting it!

Actually, the tests do fail with:
make[2]: Entering directory `/tmp/nix-build-mit-
krb5-1.11.drv-0/krb5-1.11/src/tests/resolve'
LD_LIBRARY_PATH=`echo -L../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export 
LD_LIBRARY_PATH;   ./resolve
Error looking up IP address
Hostname:  localhost
Host address: 127.0.0.1
FQDN: localhost
Resolve library appears to have passed the test
LD_LIBRARY_PATH=`echo -L../../lib | sed -e "s/-L//g" -e "s/ /:/g"`; export 
LD_LIBRARY_PATH;   ./addrinfo-test -p telnet
getaddrinfo(hostname (null), service telnet,
            hints { no-flags }):
        error => Servname not supported for ai_socktype
make[2]: *** [check] Error 1

In my non-guix environment, I obtain
privat@debian:/tmp/krb5-1.11/src/tests/resolve$ ./addrinfo-test -p telnet
getaddrinfo(hostname (null), service telnet,
            hints { no-flags }):
0x2109f40:
        family = AF_INET6       proto = TCP     socktype = STREAM
        addr = ::1                              port = 23
        getnameinfo => ip6-localhost, telnet
0x2109270:
        family = AF_INET        proto = TCP     socktype = STREAM
        addr = 127.0.0.1                        port = 23
        getnameinfo => localhost, telnet

I suppose the problem is that the telnet ports are not defined in guix; 
when I manually do
./addrinfo-test -p t
I obtain the same kind of error:
getaddrinfo(hostname (null), service t,
            hints { no-flags }):
        error => Servname not supported for ai_socktype

Instead of disabling all tests, one might patch the Makefile.in inside 
src/tests/resolve to not execute the telnet related tests.

What do you think?

Andreas

Reply via email to