Andreas Enge <[email protected]> skribis:
> Two patches attached, since "make check" did not work for libtiff with
> libjepg 9, so I also added libjpeg 8d.
Great!
> +(define-public libjpeg-8
> + (package
> + (name "libjpeg-8")
> + (version "8d")
Please, move the definition after that of ‘libjpeg’, and write it like this:
(define-public libjpeg-8
(package (inherit libjpeg)
(version "8d")
(source (origin
(method url-fetch)
(uri (string-append "http://www.ijg.org/files/jpegsrc.v";
version ".tar.gz"))
(sha256 (base32
"1cz0dy05mgxqdgjf52p54yxpyy95rgl30cnazdrfmw7hfca9n0h0"))))))
This way, only the fields that differ need to be defined.
Other than that, go ahead.
Note that I’d like to rename (distro ...), and then tag the release, so
I will ask you not to commit after this one.
Thanks!
Ludo’.
