Cyril Roelandt <[email protected]> skribis:
> * guix/build/cmake-build-system.scm, guix/build-system/cmake.scm: New files.
> * Makefile.am (MODULES): Add them.
Overall looks good to me, nice!
> +;; Standard build procedure for packages using cmake. This is implemented as
> an
Please spell it as “CMake”. Also, two spaces after a period ending a
sentence.
> +(define* (cmake-build store name source inputs
Admittedly these bits look like copy/pasting, but I’m not sure how to
factorize more.
> + (description "The standard cmake build system")
“CMake”.
> +;; XXX Parallel tests are disabled by default because I have no idea how they
> +;; work in cmake.
CMake generates a Makefile, so running ‘make -jX’ just works. Thus you
can leave #:parallel-{build,tests}? to #t by default.
> +(define* (check #:key (tests? #t) (parallel-tests? #f) (test-target "test")
> + #:allow-other-keys)
> + (let ((gnucheck (assoc-ref gnu:%standard-phases 'check)))
s/gnucheck/gnu-check/
Cool!
Please push after fixing these.
Ludo’.
