> this might have to do with the fact that until recently most Elisp > projects were organized as a single file of thousands of lines of code > ;).
Exactly! :-) > I've also factorized out the default args of the include and exclude > option of the emacs-build-system install phase. Please see the two > patches attached. Thanks! Both patches LGTM. I just have a few doubts and minor comments. > (define-module (guix build-system emacs) > + #:use-module ((guix build emacs-build-system) > + #:select (%default-include %default-exclude)) Interesting solution to the problem. I didn't think of this earlier. Importing host side to build side would be a problem, but you are importing build side to host side, and I think that's ok. > #:use-module (guix store) > #:use-module (guix utils) > #:use-module (guix packages) > @@ -28,7 +30,10 @@ > #:use-module (srfi srfi-26) > #:export (%emacs-build-system-modules > emacs-build > - emacs-build-system)) > + emacs-build-system) > + #:re-export (%default-include ;for convenience > + %default-exclude)) What is this re-export for? ert-runner seems to build fine without this. I don't understand what you mean by "convenience" here. Also, perhaps we should deduplicate default values of arguments in the gnu-build-system as well. But, I don't know if it is worth deduplicating simple default values like #t. WDYT? @Alex Kost: Please make any other changes you think are necessary, and push. Thanks!
