On Fri, Jun 23, 2017 at 03:30:10PM -0400, Leo Famulari wrote: > On Sat, Jun 03, 2017 at 12:54:46AM +0200, Ludovic Courtès wrote: > > FAIL: grub_cmd_set_date > > > All in all, I’m tempted to think this has to do with running the tests > > in parallel. > > > > As a stop-gap measure, I’ve committed a change to run tests > > sequentially. With this “guix build grub --rounds=5” passes for on my > > x86_64 laptop. Let’s reopen the bug if we find that’s not enough. > > This test just failed for me on x86_64, even with #:parallel-tests? #f. > > So, perhaps it's not an inter-test race, or perhaps the tests are still > running in parallel, or some other thing.
Spurred by another report of this test failing, here's a patch to disable it completely.
From 71299a035f793c3e2ac723b326cd881e97df6274 Mon Sep 17 00:00:00 2001 From: Leo Famulari <[email protected]> Date: Sat, 24 Jun 2017 13:17:37 -0400 Subject: [PATCH] gnu: grub: Disable a flaky test. * gnu/packages/bootloaders.scm (grub)[arguments]: Add 'disable-flaky-test' phase and run the tests in parallel. --- gnu/packages/bootloaders.scm | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index dec462b0c..9ae617528 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -91,11 +91,15 @@ ;; Make the font visible. (copy-file (assoc-ref inputs "unifont") "unifont.bdf.gz") (system* "gunzip" "unifont.bdf.gz") - #t))) - - ;; We suspect there are race conditions when running tests in parallel: - ;; <https://bugs.gnu.org/26936>. - #:parallel-tests? #f)) + #t)) + (add-before 'check 'disable-flaky-test + (lambda _ + ;; This test is unreliable. For more information, see: + ;; <https://bugs.gnu.org/26936>. + (substitute* "Makefile.in" + (("grub_cmd_date grub_cmd_set_date grub_cmd_sleep") + "grub_cmd_date grub_cmd_sleep")) + #t))))) (inputs `(("gettext" ,gettext-minimal) -- 2.13.1
signature.asc
Description: PGP signature
