[email protected] (Ludovic Courtès) writes: > [email protected] (宋文武) skribis: > >> From 6a3fa69f96fc2e3e074a9275066640ddfee57fd2 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <[email protected]> >> Date: Sat, 14 Oct 2017 22:45:55 +0800 >> Subject: [PATCH] guix: substitute: Report the last progress in the child >> process. >> >> Fixes <https://bugs.gnu.org/28756>. >> >> * guix/utils.scm (filtered-port): Close the 'input' port for the current >> process, and close it upon exit in the child process. >> * guix/scripts/substitute.scm (progress-substitution): Display "\n\n" after >> the reporter has finished. > > LGTM! > > You could commit the utils.scm change separately because it’s a bug-fix > in its own right. >
Pushed, thanks! I think the utils.scm change alone (without the remove of '(close-port progress') and comment) didn't fix this particular bug clearly so I didn't seperate it..
