> Hi, > > On Sat, 04 Aug 2018 18:10:51 +0200 > Clément Lassieur <[email protected]> wrote: > >> Clément Lassieur <[email protected]> writes: >> >> > Fixes <https://bugs.gnu.org/32300>. >> > >> > * src/cuirass/database.scm (filters->order): New procedure. >> > (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS, >> > FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures. Remove the 'LEFT JOIN >> > Outputs' clause. Use DB-GET-OUTPUTS for each build that was fetched. >> >> This may be less efficient because there are more SQL queries (one per >> output), but it's way less complicated and less buggy, so I think it's >> worth it. > > Yeah, if it's still usable, I agree. > > But I think we shouldn't overlook the possibility of not fetching the outputs > in the first place (at all).
Pushed. Thank you for the review! Clément
