Hi Eric,

(Cc Eric Bavier and Markus who may be familiar with OpenBLAS.)

Eric Brown <[email protected]> skribis:

>>From 8c9728eb66a45fd42f208df66d323981837c9c0c Mon Sep 17 00:00:00 2001
> From: Eric Brown <[email protected]>
> Date: Mon, 10 Sep 2018 08:33:43 -0500
> Subject: [PATCH] gnu: Add openblas-ilp64.
>
> * gnu/packages/maths.scm (openblas-ilp64): New variable.

[...]

> +(define-public openblas-ilp64
> +  (package
> +    (name "openblas-ilp64")
> +    (version "0.3.2")

Should we write it as:

  (package
    (inherit openblas)
    …)

?  That would avoid duplication with the ‘openblas’ package.

Also, should we add a ‘supported-systems’ field to restrict builds to
x86_64-linux, aarch64-linux, and mips64el-linux?

Apart from that it LGTM.

Thanks for the patch!

Ludo’.



Reply via email to