Efraim Flashner (2019-11-05 18:18:22 +0200) wrote: > On Tue, Nov 05, 2019 at 03:12:23PM +0100, Ludovic Courtès wrote: > > > > Ivan Vilata i Balaguer <i...@selidor.net> skribis: > > > > > Hi, I'm using patchelf 0.8 from Guix commit 7f81cce3 on Debian Sid. > > > When trying to patch the `go` binary from > > > <https://dl.google.com/go/go1.12.3.linux-amd64.tar.gz>, I get the > > > following error: > > > > > > ivan@sax /tmp/tmps2Cv6w [env]$ patchelf --print-interpreter $SHELL > > > > > > /gnu/store/ahqgl4h89xqj695lgqvsaf6zh2nhy4pj-glibc-2.29/lib/ld-linux-x86-64.so.2 > > > ivan@sax /tmp/tmps2Cv6w [env]$ patchelf --set-interpreter $(patchelf > > > --print-interpreter $SHELL) /tmp/tmps2Cv6w/golang/bin/go > > > patchelf: patchelf.cc:701: void ElfFile<Elf_Ehdr, Elf_Phdr, Elf_Shdr, > > > Elf_Addr, Elf_Off, Elf_Dyn, Elf_Sym>::rewriteSectionsExecutable() \ > > > [with Elf_Ehdr = Elf64_Ehdr; Elf_Phdr = Elf64_Phdr; Elf_Shdr = > > > Elf64_Shdr; Elf_Addr = long unsigned int; Elf_Off = long unsigned int; \ > > > Elf_Dyn = Elf64_Dyn; Elf_Sym = Elf64_Sym]: Assertion `(off_t) > > > rdi(hdr->e_shoff) >= startOffset' failed. > > > Aborted > > > > I think it’s a bug you should report upstream to the PatchELF > > maintainers; it’s probably not Guix-specific. > > On the other hand, if I were the patchelf maintainers, I'd suggest > upgrading our package from 0.8 to a newer version.
Yeah, as I mentioned in the original mail that particular problem does indeed seem to be fixed in 0.10. However when I try to build that source with `guix build patchelf --with-source=…`, tests fail. If I run `guix environment -C --pure patchelf` then unpack and build the source, the only test that actually fails is `no-rpath.sh`. If I run `sh -x no-rpath.sh` I get this: ``` ++ basename no-rpath.sh .sh + SCRATCH=scratch/no-rpath + rm -rf scratch/no-rpath + mkdir -p scratch/no-rpath + cp no-rpath scratch/no-rpath/ ++ ../src/patchelf --print-rpath scratch/no-rpath/no-rpath + oldRPath=/gnu/store/ahqgl4h89xqj695lgqvsaf6zh2nhy4pj-glibc-2.29/lib:/gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib:/gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/gcc/x86_64-unknown-linux-gnu/7.4.0/../../..:/gnu/store/dcrwf5irwh39knld1wim1qkny659af9g-profile/lib + test -n /gnu/store/ahqgl4h89xqj695lgqvsaf6zh2nhy4pj-glibc-2.29/lib:/gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib:/gnu/store/2plcy91lypnbbysb18ymnhaw3zwk8pg1-gcc-7.4.0-lib/lib/gcc/x86_64-unknown-linux-gnu/7.4.0/../../..:/gnu/store/dcrwf5irwh39knld1wim1qkny659af9g-profile/lib + exit 1 ``` To succeed, the output of `…/patchelf --print-rpath …/no-rpath` (i.e. `oldRPath`) should be empty. I'm not that familiar with Guix's GNU build system, but is that at all possible under Guix? I mean, maybe the test is pointless or must be altered in some Guix-specific way for the `no-rpath` binary not to have an rpath. Cheers, -- Ivan Vilata i Balaguer -- https://elvil.net/