Hi! Miguel Ángel Arruga Vivas <[email protected]> skribis:
> From 527a9271122f7b83f31dc0b910c6704af81bde66 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?= > <[email protected]> > Date: Sat, 24 Oct 2020 18:15:53 +0200 > Subject: [PATCH 2/2] system: Add store-directory-prefix to boot-parameters. > > * gnu/machine/ssh.scm (roll-back-managed-host): Use > boot-parameters-store-directory-prefix. > * gnu/system.scm (define-module): Export > boot-parameters-store-directory-prefix. > (<boot-parameters>)[store-directory-prefix]: New field. > [boot-parameters-store-directory-prefix]: New accessor. > (read-boot-parameters): Read directory-prefix from store field. > (operating-system-boot-parameters-file): Add directory-prefix to > store field. > * guix/scripts/system.scm (reinstall-bootloader): Use > boot-parameters-store-directory-prefix. > * test/boot-parameters.scm (%default-btrfs-subvolume, > %default-store-directory-prefix): New variables. > (%grub-boot-parameters): Use %default-store-directory-prefix. > (%default-operating-system): Use %default-btrfs-subvolume. > (test-boot-parameters): Add directory-prefix. > (test optional fields): Add test for directory-prefix. > (test os store-directory-prefix): New test. [...] > +++ b/gnu/system.scm > @@ -148,6 +148,7 @@ > boot-parameters-bootloader-name > boot-parameters-bootloader-menu-entries > boot-parameters-store-device > + boot-parameters-store-directory-prefix > boot-parameters-store-mount-point > boot-parameters-locale > boot-parameters-kernel > @@ -299,6 +300,7 @@ directly by the user." > boot-parameters-bootloader-menu-entries) > (store-device boot-parameters-store-device) > (store-mount-point boot-parameters-store-mount-point) > + (store-directory-prefix boot-parameters-store-directory-prefix) Could you explain why we need ‘store-directory-prefix’ in addition to ‘store-mount-point’? At first sight, looking at the fields in there, these two can seem to be synonymous. Also patch #3 doesn’t depend on it, does it? Thanks, Ludo’.
