Hi, Ludovic Courtès <[email protected]> writes:
> Hi, > > Maxime Devos <[email protected]> skribis: > >> Actually, glib's build system (meson-build-system) did not support >> cross-compilation at all before the merge. Cross-compilation support >> was added on that branch, but glib's package broke later, presumably in >> <https://git.savannah.gnu.org/cgit/guix.git/commit/?id=f22f6fc3b6cc6382df3246d192a40a3951b48c37>. >> >> The fix would be to replace to wrap the configure flags in a #~, >> instead of a ´,replace (assoc-ref %outputs "bin") by #$output:bin and >> adjust the configure flags of glib-with-documentation to use #~ and #$ >> instead of ´ and ,. >> >> To avoid rebuilds, some >> (if (%current-target-system) #~#$output:bin #~(assoc-ref %outputs >> "bin")) >> may be needed. > > In the case of ‘meson-build-system’, the logical fix IMO would be to > define ‘%build-inputs‘, ‘%outputs’, etc. when cross-compiling, with the > patch below. > > This would be consistent with the fact that ‘meson-build-system’ defines > those variables for native builds already. > > Thoughts? > > Longer-term we can move away from ‘%outputs’, ‘%build-inputs’, & co., > but that’s another story. Seems the proper fix; I'm just wondering; could there be other build systems that were overlooked needing the same fix? If so, we should fix them now too.
