Hi Oleg, Maxim Cournoyer <[email protected]> writes:
> Hi, > > Maxim Cournoyer <[email protected]> writes: > >> Hi Oleg, >> >> Oleg Pykhalov <[email protected]> writes: >> >>> Fixes <https://issues.guix.gnu.org/38432>. >>> >>> * gnu/packages/patches/containerd-create-pid-file.patch: New file. >>> * gnu/local.mk (dist_patch_DATA): Add this. >>> * gnu/packages/docker.scm (containerd)[source]: Add this patch. >>> * gnu/services/docker.scm >>> (containerd-shepherd-service): Add #:pid-file and #:pid-file-timeout. >>> * gnu/services/docker.scm (docker-shepherd-service): Add --containerd flag. >> >> Thanks for this, it looks promising! [...] > All that to say that I shall be reviewing your patches shortly :-). Now done; it all looks good to me! I've run the docker system test, and installed it on my machine, rebooted, confirmed it was up, restarted containerd a couple times and checked the PID content matched its actual PID, and it seems to behave as expected! Pushed as b33e1a183f6756514e6b6a3b84054a232dbddad4. Thank you! Maxim
