On Sat, Oct 8, 2022 at 11:16 AM zimoun <zimon.touto...@gmail.com> wrote: > > Hi Dave, > > On Thu, 06 Oct 2022 at 09:26, "Thompson, David" <dthomps...@worcester.edu> > wrote: > > > Some news: I have updated the gitolite package to use G-expressions. > > The package builds and the gitolite system test passes so I pushed > > that change to master a little while ago. That patch has made the > > (hopefully) final step in this saga easier. The attached patch > > introduces a 'make-gitolite' procedure that can be used to add > > arbitrary packages to the wrappers for the gitolite and gitolite-shell > > programs. The return value of this procedure can be used in the > > gitolite service configuration to enable the desired optional features > > like Redis or git-annex. The base package inputs are unchanged and > > the gitolite system test still passes. > > Thank you for working on this! Neat. > > Well, your proposal LGTM although I do not see the difference between > ’make-gitolite’ and a simple ’inherent’ for building a package variant. > Yeah, this make-gitolite is probably more handy.
The reason for the constructor is so that extra packages can be easily added to the gexp that calls wrap-program. It would be much harder to modify the package in this way without a helper procedure. - Dave
