Hi, Mathieu Othacehe <[email protected]> skribis:
> I tested it out and I had several SCM pointers encapsulating the same > libparted C pointer, thus multiple finalizers on the same underlying C > pointer. Yes, that’s the idea I tried to convey. > Anyway, here is a patch that solves the issue by removing the device > finalizer. It also means that all devices are persisted until the end of > the program which doesn't feel right, but I cannot think of a better > solution. Looking at device.c in Parted, that’s probably the right thing because PedDevice objects are kept in a linked list whose head is stored in the ‘devices’ global variable of device.c. So you cannot just free them asynchronously from a finalizer thread because they might still be accessed from other parts of the library. This is the explanation that should go in the comment, and it’s clearly a good reason not to free those PedDevice objects. Now, we could provide bindings for ‘ped_device_destroy’ that users could explicitly call if they want to (this would be similar to explicit calls to ‘close-port’). We’d arrange to make it idempotent. Thanks, Ludo’.
