Hi Ludovic, Ludovic Courtès <[email protected]> writes:
> Hi, > > Maxim Cournoyer <[email protected]> skribis: > >> Simon Tournier <[email protected]> writes: >> >>> Hi Ludo, >>> >>> On Tue, 03 Jan 2023 at 23:29, Ludovic Courtès <[email protected]> wrote: >>> >>>> The manual recommends this (info "(guix) Teams"): >>>> >>>> git send-email --to [email protected] $(./etc/teams.scm cc >>>> mentors) *.patch >>>> >>>> where: >>>> >>>> --8<---------------cut here---------------start------------->8--- >>>> λ ./etc/teams.scm cc mentors >>>> --add-header="X-Debbugs-Cc: [email protected]" >>>> --add-header="X-Debbugs-Cc: [email protected]" … >>>> --8<---------------cut here---------------end--------------->8--- >>>> >>>> I believe this cannot work because the shell will split words on each >>>> whitespace; IOW, the double quotes above do not have the desired effect. >> >>> Well, IIUC, this part is tracked by #58813 [1]. >>> >>> 1: <http://issues.guix.gnu.org/issue/58813> >> >> Indeed (CC'd). >> >> I thought about not using whitespace in the generated output, but I'm >> not sure if Debbugs or email clients in general would care, plus it's a >> dirty fix. > > Right. > > How about just outputting a line like: > > X-Debbugs-Cc: [email protected], [email protected] > > that people would paste in their cover letter? Yes, that's better. > How do Linux’s scripts work? I think the scripts just print stuff at the terminal and expect the user to copy paste. Patman can be used to provide automation on top of that. >> With the recent patman integration merged (though do apply #60576 as a >> fixup commit), I'm tempted to remove the mentions of git send-email >> $(etc/teams.scm cc-members ...) and replace that by 'Further automation >> of git send-email and etc/teams.scm is possible via the patman package'. >> >> What do you think? > > This is the first time I hear about patman. :-) > > The “Submitting Patches” section mentions ‘git send-email’; I don’t > think this is about to change, is it? It wouldn't change; patman would be hinted at briefly with a reference to its documentation (info '(u-boot) Patman patch manager' from the u-boot-documentation package) as a nice way to stay organize with submissions and automate a few things on top of git send-email. -- Thanks, Maxim
