Hi, Tomas Volf <[email protected]> writes:
> Carlo Zancanaro <[email protected]> writes: > >> On Thu, May 14 2026, Tomas Volf wrote: >>> I have encountered bug with the hook we install for adding Change-Id >>> trailer. It for some reason inserts it as a first line of the commit >>> message instead of at the end. Would you mind to share how to reproduce the issue? It isn't obvious to me. [...] >> I'm not sure why we're limiting ourselves to git versions and features >> from 2017. > > Given that the commit-msg hook has this header > > # From Gerrit Code Review 3.11.1. > # > # Part of Gerrit Code Review (https://www.gerritcodereview.com/) > # > # Copyright (C) 2009 The Android Open Source Project > > I would not rule out the option that Maxim just added it without > considering this particular detail. I took the liberty of CC-ing him, > maybe he could answer this bit. It's, as the copyright suggests, a script borrowed from the Gerrit project :-). It hasn't been modified. About the ways we call it, if it resolves a clear issue, we do not need to constrain ourselves to an old git version the same the gerrit project might; using the git version which is in our current master tree would be fine, I think. -- Thanks, Maxim
