On 13 March 2014 19:11, Reuben Thomas <[email protected]> wrote: > On 13 March 2014 17:38, Jim Meyering <[email protected]> wrote: >> >> On Thu, Mar 13, 2014 at 10:33 AM, Sami Kerola <[email protected]> wrote: >> > Long answer: unless someone objects I'll push the following to upstream. >> > >> > --->8---- >> > From: Sami Kerola <[email protected]> >> > Date: Thu, 13 Mar 2014 17:18:36 +0000 >> > Subject: [PATCH] build: parallel-tests require of TESTS_ENVIRONMENT >> > >> > * Makefile.am: Tests failed in Travis-CI's servers because missing >> > environment variables. Looking the automake documentation the >> > AM_TESTS_ENVIRONMENT cannot be used in combination with parallel-tests, >> > and such cases TESTS_ENVIRONMENT should be used instead. > > The fix is correct, but the reasoning is not: AM_TESTS_ENVIRONMENT *can* and > *should* be used with parallel-tests, but only in automake > 1.11. > > It is serial-tests that *requires* TESTS_ENVIRONMENT even in later automake.
Reuben you are right. I read the parallel and serial test requirements wrong way around. In GNU Hello configure.ac requires automake 1.11.1 or newer, and that is in conflict with breakage report from Gordon. Looking the automake NEWS file 1.12 has lots of changes to testsuite. Automake in broken build https://travis-ci.org/agordon/gnuhello/jobs/20581026 seems to be 1.11.3, while mine is 1.14.1. Gordon, would it be too much trouble to update automake and see if that would fix the issue? -- Sami Kerola http://www.iki.fi/kerolasa/
