On Sun, Feb 10, 2002 at 01:57:20PM -0500, James A Morrison wrote: > These should be last references to dir_pathtrans left in the hurd sources.
I have applied (most) of your changes. But here are some of the unbreakable rules from the bible of submitting patches ;) 1. You shall write proper english sentences in the ChangeLog. 2. You shall submit one ChangeLog entry for each ChangeLog, so as they can be cutted and pasted into them individually. 3. Following 2, you shall list the file name relative to the directory the ChangeLog is in. 4. You shall add a copyright year for the year the file was changed in, but not for years between the last change and the year you changed it. 5. You shall collect the years in a long copyright line, first by leaving out the first two digits in subsequent years (1994,95,...), then by using ranges where applicable. You shall not split up a copyright line. 6. You shall fix the formatting of the surrounding code and text when doing changes that affect formatting. Like the line following the changed line here: > - else if (err = dir_pathtrans (root, "CREATED", O_WRITE | O_CREAT, 0666, > + else if (err = dir_lookup (root, "CREATED", O_WRITE | O_CREAT, 0666, > &retry, pathbuf, &filetowrite)) That's all for now :) Note that we try to garbage collect random changes to comments for the time we have to make a substantial change to the code (so they don't clutter up the CVS history). In this case, I think cleaning up the traces of an interface name change is justified, so it doesn't apply here. Thanks, Marcus -- `Rhubarb is no Egyptian god.' Debian http://www.debian.org [EMAIL PROTECTED] Marcus Brinkmann GNU http://www.gnu.org [EMAIL PROTECTED] [EMAIL PROTECTED] http://www.marcus-brinkmann.de _______________________________________________ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd
