Samuel Thibault wrote:
Barry deFreese, le Sun 20 Jul 2008 23:46:24 -0400, a écrit :* i386/i386/ipl.h (ivect[]): return void instead of int. * i386/i386at/com.c (comintr, comstop): Return 0 at end of function.Err, that's not coherent: comintr is put in ivect...
Aye missed that updating now.
* i386/i386/trap.c (user_trap): Return 1 if end of function is reached.See the comment: /*NOTREACHED*/ So there shouldn't be a need for a return here. Add __attribute__((noreturn)) to i386_exception and similar instead, see Debugger for instance.
Updating and rebuilding.
I will look at evc_wait_clear but I was getting a warning on this line but now I see your point. I'm looking at this one again.Index: kern/eventcount.c =================================================================== RCS file: /sources/hurd/gnumach/kern/eventcount.c,v retrieving revision 1.1.1.1.4.7 diff -u -p -r1.1.1.1.4.7 eventcount.c --- kern/eventcount.c 3 Dec 2006 21:50:20 -0000 1.1.1.1.4.7 +++ kern/eventcount.c 21 Jul 2008 03:21:06 -0000 @@ -177,7 +177,7 @@ kern_return_t evc_wait(natural_t ev_id) thread_block(evc_continue); return KERN_SUCCESS; } - ret = KERN_NO_SPACE; /* XX */ + return KERN_NO_SPACE; /* XX */ } simple_unlock(&ev->lock); splx(s);Err, no, the simple_unlock() will not be done! What needs to be fixed (and what I was talking about on irc) was evc_wait_clear! Samuel
Sorry, Barry
