Hi, since 2.16, glibc dropped support for any binary format other than ELF; the removal of the 'elf' variable causes libpthread.so to not link, since ld.so is not passed to the linking line. The attached patch defines elf to yes if not defined, allowing to keep compatibility also with glibc < 2.16.
Also, I'm slightly in doubt about the ChangeLog snippet, not totally sure about how to write it properly in this case. -- Pino Toscano
From 64d00b6482f03f7dfb6f3d4775a9bf44e53cec63 Mon Sep 17 00:00:00 2001 From: Pino Toscano <toscano.p...@tiscali.it> Date: Fri, 16 Nov 2012 15:04:29 +0100 Subject: [PATCH] Set elf=yes if not defined already glibc 2.16 dropped support for any binary format other than ELF, and the ELF variable has been removed too; this causes a build failure when built as glibc addon with glibc >= 2.16, since it would not link to ld.so. Defining ELF to 'yes' if not defined allows to retain compatibility with older glibc versions. * Makefile [$(..) != ''] [$(elf) = ''] (elf): Define to 'yes'. --- Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Makefile b/Makefile index fdfe3ae..c1d8d33 100644 --- a/Makefile +++ b/Makefile @@ -22,6 +22,10 @@ IN_GLIBC = no else # glibc build IN_GLIBC = yes +# set elf=yes, to retain compatibility with glibc < 2.16 +ifeq ($(elf),) +elf = yes +endif endif ifeq ($(IN_GLIBC),no) -- 1.7.10.4
signature.asc
Description: This is a digitally signed message part.