>>>>> "Tom" == Tom Tromey <t...@tromey.com> writes:

>>>>> "Thomas" == Thomas Schwinge <tho...@codesourcery.com> writes:
Thomas> +             struct cleanup *old_chain = make_cleanup (xfree, 
pathname);

Tom> Please don't add new cleanups to gdb.
Tom> We're in the process of removing them all.

Tom> Instead you can use gdb::unique_xmalloc_ptr<char>, or std::string, or a
Tom> std::vector of some flavor.

I went ahead and added a patch to fix this to my series to remove
cleanups, so you don't need to do anything about this one.

Tom

Reply via email to