On Tue, Feb 14, 2023 at 2:51 PM Samuel Thibault <[email protected]> wrote:
> Sergey Bugaev, le mar. 14 févr. 2023 22:48:18 +0300, a ecrit: > > On Tue, Feb 14, 2023 at 10:20 PM Samuel Thibault > > <[email protected]> wrote: > > > > > +#if defined(__x86_64__) && !defined(USER32) > > > > > + uint64_t efl; > > > > > > > > Should this not be 'rfl' (for 'rflags')? > > > > > > In both cases, that would make the gnumach code have to distinguish the > > > two names, in the debugger and various other places. > > > > Yes, > > Sorry, I got back to this mail and confused my first and second reading, > then mistaking your sentence for the internal structure. > > What I said is only concerning the internal structure. > > For this efl flag, I don't have any idea why flavio let it as efl. > No strong reason, I was just trying to avoid touching the code below that also relies on this field, but I think it makes sense to have a clean public interface. > Samuel >
