? I don't see the point of changing the address. This instruction doesnt modify the content of the pointed data.
And even if modifying the address was needed, the redzone is 128 bytes. And we don't actually need it to be 8-byte, 4-byte will bring the same barrier, and takes one byte less. I have just changed esp into rsp. Damien Zammit, le ven. 02 janv. 2026 04:15:56 +0000, a ecrit: > --- > x86_64/spl.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/x86_64/spl.S b/x86_64/spl.S > index 80c65c1e..b00b8153 100644 > --- a/x86_64/spl.S > +++ b/x86_64/spl.S > @@ -24,7 +24,7 @@ > #include <i386/cpu_number.h> > > #if NCPUS > 1 > -#define mb lock; addl $0,(%esp) > +#define mb lock; addq $0,-8(%rsp) > #else > #define mb > #endif > -- > 2.45.2 > > >
