Hello, Just a quick comment,
Milos Nikic, le mar. 10 févr. 2026 10:10:44 -0800, a ecrit: > For the discussion from 8)... some of the file system operations are happening > completely inside libdiskfs, dir_rename, link, unlink, set trans etc etc. > In order to support that properly we would need access to journal inside > libdiskfs, but the journal is very ext2 specific. > To make this possible my plan would be to follow the existing pattern in Hurd > and add Journaling functions inside libdiskfs as weak symbols (so that they > don't do anything for other filesystems). > These 4 would probably suffice: > diskfs_journal_start_transaction() > diskfs_journal_stop_transaction() > diskfs_journal_commit_transaction() > diskfs_journal_is_running() > (diskfs_notify_change could be removed if we have these!!) Yes, that'd be fine. > Yet ext2fs (or other file systems if there is a need) will implement them and > have it working correctly. > I didn't want to bundle that in this patch, because it would add many more > files (somewhere around 10) and its already getting large. It's fine. We don't want to commit something which is not actually providing the safety that people expect from a journaling filesystem. Samuel
