Hello,

[email protected], le mar. 24 févr. 2026 04:27:55 +0100, a ecrit:
> The commit message says "curr_spl is actually 4 bytes", but on x86_64,
> spl_t is typedef'd as unsigned long (i386/i386/spl.h line 34)

I guess it's reading its own source code, where that was patched into
long.

> 1. (Brent's suggestion) Rename CX to CX4.

Yes, that'd probably be more expressive.

> 2. (My suggestion) Consider a CX16 macro for the kernel_timer case.
>    The CX(CX()) double-nesting works but is fragile — it relies on
>    4*4=16, which is a coincidence of the current timer structure size.

The fact that 4*4=16 is not actually related to the timer structure
size. Having CX16 use CX4(CX4()) will be always correct (as long as
4*4=16...)

Samuel

Reply via email to