On Thursday 17 May 2007 19:02:14 david wrote: > Jean-Christophe, > Please send the update again. The bug-indent filter seems to have > removed your attachment.
OK, I will. > I would prefer it if you send the whole updated files rather than > patches as then I can see your updates in the context of the version of > the file you actually updated - which may be older than the current SVN > head. The README seems to imply you preffer "diff" patches. Is the SVN "public"? Where can we reach it? > I hope you also send updates to the documentation, as without them > your update is worthless. Sorry I am not a documentation expert and ROFF is a bit alien to me. Now I can try. Could you tell me what file should be updated? indent.html, indent.texinfo, indent.info, indent.1, indent.1.in? all of them? Is one of these files driving the other ones? > If I were reviewing your code I'd say that you should get rid of the > labels and goto's altogether :-) Well I would agree except when cleaning up resources after an error happens ... Anyway it would be nice to be able to control the label placement. > > Jean-Christophe Dubois wrote: > > Hi, > > > > I'd like to propose a patch to ease the "linux coding style" with indent. > > > > in the Linux source tree there is a script that shows the recommended > > Linux coding style using indent in scripts/Lindent. The content is as > > follow: > > > > #!/bin/sh > > indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs "$@" > > > > So indent is almost there. However, anytime I post an "indented" file > > with labels on a linux mailing list, I am told that any (goto) label > > should start at column 1 always. I don't think there is any option in the > > actual indent to force (goto) label to start at column 1. > > > > So this is what my attached patch is doing. It adds an option to specify > > the label offset and also add a "linux" profile that sums up the above > > line with the new "label offset" option. > > > > Note that if the label offset option is not specified on the command line > > then there should be no change in behavior compared to the "old" indent. > > > > I have not updated the documentation (man, ...) with the new option. > > > > Thanks. > > > > JC > > > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > bug-indent mailing list > > [email protected] > > http://lists.gnu.org/mailman/listinfo/bug-indent _______________________________________________ bug-indent mailing list [email protected] http://lists.gnu.org/mailman/listinfo/bug-indent
