Collin Funk <collin.fu...@gmail.com> writes: > Hi Simon, > > Are you okay with me pushing the following two patches? > > Patch 0001 removes most (all?) of the extern function decls that > should be in the standard library. They seems harmless, but maybe they > can mess with Gnulib declarations. We should probably just rely on > those anyways. > > Patch 0002 removes the use of the 'register' keyword. NetBSD did this > 20 years ago [1][2]. I assume the other BSDs did too, but NetBSD seems > closer to what we have. So this frivolous change should actually make > it easier to diff. :)
These looks good to me, thank you! Please push them. Btw, if you are used to working on gitlab -- to get feedback from CI/CD testing directly -- you can push test branches to your personal fork of https://gitlab.com/gsasl/inetutils and add "gnu/inetutils.yml@gnulib/pipeline" as the Settings -> CI/CD -> General pipelines -> CI/CD configuration file. Working with gitlab has its own set of issues, so there is no requirement to do this, but if you happen to be fluent with gitlab this may help improve your contributions. /Simon
signature.asc
Description: PGP signature
