Hi Simon,

On Thu, May 02, 2024 at 08:25:24PM +0200, Simon Josefsson wrote:
> Erik Auerswald <auers...@unix-ag.uni-kl.de> writes:
> > On Thu, May 02, 2024 at 08:08:07PM +0200, Simon Josefsson wrote:
> >> tor 2024-05-02 klockan 20:05 +0200 skrev Erik Auerswald:
> >> > On Thu, May 02, 2024 at 07:55:23PM +0200, Simon Josefsson via Bug
> >> > reports for the GNU Internet utilities wrote:
> >> > > [...]
> >> > > I worry about self-tests though, it would be nice to beef up on
> >> > > that.
> >> > > There is a pretty substantial GNU/Linux-centric self-test pipeline
> >> > > here
> >> > > (I just noticed the last commit broke this due to indentation
> >> > > changes):
> >> > > 
> >> > > https://gitlab.com/gsasl/inetutils/-/pipelines
> >> > [...]
> >> Don't worry -- that's what the pipeline is there for, and it is easy to
> >> fix.  Could you run 'make indent' using a recent GNU indent and push
> >> the fix?
> > [...]
> > But I can manually break the line as shown in
> > <https://gitlab.com/gsasl/inetutils/-/jobs/6731453789>:
> >
> >     -     addr.s_addr = n ? htonl (INADDR_BROADCAST << (32 - n)) : 
> > INADDR_ANY;
> >     +     addr.s_addr =
> >     +       n ? htonl (INADDR_BROADCAST << (32 - n)) : INADDR_ANY;
> >           str = strdup (inet_ntoa (addr));
> > [...]
> > Anyway, manually adding the line break and further indentation removes
> > "ifconfig" from the output of "make syntax-check", so I'll just push
> > that in a moment.

The pipeline still fails, but now it is while attempting to download
gnulib.  This should not be caused by my commits, and I know nothing
about gnulib or the GitLab pipeline.

Best regards,
Erik

  • Is TODO up-... Collin Funk
    • Re: Is... Simon Josefsson via Bug reports for the GNU Internet utilities
      • Re... Erik Auerswald
        • ... Simon Josefsson via Bug reports for the GNU Internet utilities
          • ... Erik Auerswald
            • ... Simon Josefsson via Bug reports for the GNU Internet utilities
              • ... Erik Auerswald
              • ... Collin Funk
                • ... Simon Josefsson via Bug reports for the GNU Internet utilities
                • ... Collin Funk
      • Re... Collin Funk

Reply via email to