Hi Brandon:

Thanks much for your patch! This is great! Your changes will land in the next version of LibreJS. I haven't had much time to look into Make as much as I ought to. One of the things the makefile does is to run `cfx xpi'. I remember posting information on the best way to do make "activate" permanent on a GNU/Linux system, but I can't find it anymore. There are instruction in the Mozilla Addon SDK document. You can see the installation guide on how to activate it and make it permanent:
https://addons.mozilla.org/en-US/developers/docs/sdk/latest/dev-guide/tutorials/installation.html

I've tried to figure out a way to make this a little smoother with the makefile. Would you have any recommendation on how to proceed?

Thanks for your and patch and for your input!

Loic


On 11/01/2012 06:56 AM, Brandon Invergo wrote:
Hi,

I'm the maintainer of GSRC (GNU Source Release Collection), which uses
Makefile trickery to install GNU software from source, usually to a
non-standard location (i.e. /gnu or ~/gnu instead of /usr).

I've attached a patch for the LibreJS Makefile to better support installing
to non-standard locations through the addition of the DESTDIR, prefix
and libdir variables.

It also replaces the calls to mkdir with install -d, for the odd occasion
in which the user is installing the plugin when the $(libdir)/mozilla
directory doesn't exist due to the user not having a Mozilla-based
browser installed yet.

I've tested this against the just-released librejs 4.9, but since it's
not really interfering with the code, I can't imagine that it will fail
on the latest repo trunk. Nevertheless, if you would prefer that I patch
against that, let me know.

Cheers,
Brandon Invergo

ps - I'm not subscribed to the list so please CC me in your response
pps - Thanks for this great plugin!





Reply via email to